netudima commented on code in PR #4166: URL: https://github.com/apache/cassandra/pull/4166#discussion_r2160306926
########## bin/cassandra: ########## @@ -174,6 +174,23 @@ case "`uname -s`" in ;; esac +clean_heap_dump_files() +{ + if [ "$CASSANDRA_HEAPDUMP_CLEAN" != "" ] && \ Review Comment: what about using CASSANDRA_HEAPDUMP_KEEP_NEWEST_N_FILES instead of CASSANDRA_HEAPDUMP_CLEAN? It is more self-explanatory.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org