dcapwell commented on code in PR #207:
URL: https://github.com/apache/cassandra-accord/pull/207#discussion_r2153310896
##########
accord-core/src/main/java/accord/topology/Topology.java:
##########
@@ -638,7 +643,7 @@ public Ranges ranges()
return subsetOfRanges;
}
- public Set<Id> staleIds()
+ public SortedArrayList<Id> staleIds()
Review Comment:
`accord.topology.Topology#Topology(long,
accord.utils.SortedArrays.SortedArrayList<accord.local.Node.Id>,
accord.topology.Shard...)`
we take a `SortedArrayList` as part of our public api, so this just makes it
easier for C* to work with it and avoid having to cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
