belliottsmith commented on code in PR #207:
URL: https://github.com/apache/cassandra-accord/pull/207#discussion_r2185098768
##########
accord-core/src/main/java/accord/utils/SortedArrays.java:
##########
@@ -1793,4 +1794,29 @@ private static void swap(int[] values, int i, int j)
values[i] = values[j];
values[j] = t;
}
+
+ public static <T extends Comparable<? super T>> BitSet
toBitSet(SortedArrays.SortedArrayList<T> src,
+
SortedArrays.SortedArrayList<T> subset)
+ {
+ BitSet bitSet = new BitSet(src.size());
+ for (int i = 0; i < src.size(); i++)
+ {
+ if (subset.contains(src.get(i)))
+ bitSet.set(i);
+ }
+ return bitSet;
+ }
+
+ public static <T extends Comparable<? super T>>
SortedArrays.SortedArrayList<T> fromBitSet(SortedArrays.SortedArrayList<T> src,
+
BitSet bitSet,
Review Comment:
More consistent to use `SimpleBitSet` here as well, since this is what this
codebase uses primarily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
