nikhilkumawat03 commented on code in PR #4228: URL: https://github.com/apache/cassandra/pull/4228#discussion_r2193499376
########## test/unit/org/apache/cassandra/cql3/SimpleQueryTest.java: ########## @@ -561,6 +564,32 @@ public void testSStableTimestampOrdering() throws Throwable assertRows(execute("SELECT * FROM %s WHERE k1=1"), row(1, 1, 2)); } + @Test + public void testInvalidCompactionOptions() + { + try + { + createTable("CREATE TABLE %s.test (k int PRIMARY KEY, v int) WITH compaction = {" + + "'class': 'LeveledCompactionStrategy', " + + "'fanout_size': '90', " + + "'sstable_size_in_mb': '1089'}"); + fail("fanout_sizeed and sstable_size_in_mb are invalid, but did not throw ConfigurationException"); + } + catch (ConfigurationException e) + { + assertTrue(e.getMessage().contains("your maxSSTableSize must be absurdly high to compute")); + } + } + + @Test + public void testValidCompactionOptions() + { + createTable("CREATE TABLE %s.test (k int PRIMARY KEY, v int) WITH compaction = {" + + "'class': 'LeveledCompactionStrategy', " + + "'fanout_size': '10', " + Review Comment: Removed this test case as it is already covering in `est//unit/org/apache/cassandra/db/compaction/CompactionsCQLTest.java`. ########## test/unit/org/apache/cassandra/db/compaction/LeveledCompactionStrategyTest.java: ########## @@ -969,6 +969,34 @@ public void testReduceScopeL0L1() throws IOException } } + @Test() + public void testInvalidFanoutAndSSTableSize() + { + try + { + Map<String, String> options = new HashMap<>(); + options.put("class", "LeveledCompactionStrategy"); + options.put("fanout_size", "90"); + options.put("sstable_size_in_mb", "1089"); + LeveledCompactionStrategy.validateOptions(options); + Assert.fail("fanout_sizeed and sstable_size_in_mb are invalid, but did not throw ConfigurationException"); Review Comment: added expectedFailure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org