nikhilkumawat03 commented on code in PR #4228:
URL: https://github.com/apache/cassandra/pull/4228#discussion_r2193500601


##########
test/unit/org/apache/cassandra/cql3/SimpleQueryTest.java:
##########
@@ -561,6 +564,32 @@ public void testSStableTimestampOrdering() throws Throwable
         assertRows(execute("SELECT * FROM %s WHERE k1=1"), row(1, 1, 2));
     }
 
+    @Test
+    public void testInvalidCompactionOptions()
+    {
+        try
+        {
+            createTable("CREATE TABLE %s.test (k int PRIMARY KEY, v int) WITH 
compaction = {" +
+                    "'class': 'LeveledCompactionStrategy', " +

Review Comment:
   @Maxwell-Guo CQL statement is made in the single line and test case is moved 
to CreateTableValidationTest.java, @dcapwell I considered 
LevelCompactionStrategyValidationTest.java but a similar naming convention 
'LevelCompactionStrategyTest.java' is used for programmatical 
'LevelCompactionStrategy' tests but not for 'CREATE TABLE' statements like test 
cases. Hence, put the test case in 'CreateTableValidationTest.java'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to