Mmuzaf commented on code in PR #2497:
URL: https://github.com/apache/cassandra/pull/2497#discussion_r2198152442
##########
src/java/org/apache/cassandra/tools/nodetool/GarbageCollect.java:
##########
@@ -17,30 +17,40 @@
*/
package org.apache.cassandra.tools.nodetool;
-import io.airlift.airline.Arguments;
-import io.airlift.airline.Command;
-import io.airlift.airline.Option;
-
import java.util.ArrayList;
import java.util.List;
+import org.apache.cassandra.schema.CompactionParams;
import org.apache.cassandra.tools.NodeProbe;
-import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
+
+import org.apache.cassandra.tools.nodetool.layout.CassandraUsage;
+import picocli.CommandLine.Parameters;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
+import static
org.apache.cassandra.tools.nodetool.CommandUtils.parseOptionalKeyspace;
+import static
org.apache.cassandra.tools.nodetool.CommandUtils.parseOptionalTables;
+import static org.apache.cassandra.tools.nodetool.CommandUtils.concatArgs;
@Command(name = "garbagecollect", description = "Remove deleted data from one
or more tables")
-public class GarbageCollect extends NodeToolCmd
+public class GarbageCollect extends AbstractCommand
{
- @Arguments(usage = "[<keyspace> <tables>...]", description = "The keyspace
followed by one or many tables")
+ @CassandraUsage(usage = "[<keyspace> <tables>...]", description = "The
keyspace followed by one or many tables")
private List<String> args = new ArrayList<>();
- @Option(title = "granularity",
- name = {"-g", "--granularity"},
- allowedValues = {"ROW", "CELL"},
- description = "Granularity of garbage removal. ROW (default) removes
deleted partitions and rows, CELL also removes overwritten or deleted cells.")
- private String tombstoneOption = "ROW";
+ @Parameters(index = "0", description = "The keyspace followed by one or
many tables to garbage collect", arity = "0..1")
+ private String keyspace;
- @Option(title = "jobs",
- name = {"-j", "--jobs"},
+ @Parameters(index = "1..*", description = "The tables to garbage collect",
arity = "0..1")
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
