Mmuzaf commented on code in PR #2497:
URL: https://github.com/apache/cassandra/pull/2497#discussion_r2200078313
##########
src/java/org/apache/cassandra/tools/nodetool/SetConcurrency.java:
##########
@@ -55,7 +56,6 @@ public void execute(NodeProbe probe)
{
String message = e.getMessage() != null ? e.getMessage() :
"invalid pool size";
probe.output().out.println("Unable to set concurrency: " +
message);
- System.exit(1);
Review Comment:
Fixed.
##########
src/java/org/apache/cassandra/tools/nodetool/SetAutoRepairConfig.java:
##########
@@ -33,31 +28,40 @@
import java.util.Objects;
import java.util.Set;
+import org.apache.cassandra.tools.NodeProbe;
+import picocli.CommandLine.Parameters;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
import static com.google.common.base.Preconditions.checkArgument;
/**
* Allows to set AutoRepair configuration through nodetool.
*/
@Command(name = "setautorepairconfig", description = "sets the autorepair
configuration")
-public class SetAutoRepairConfig extends NodeToolCmd
+public class SetAutoRepairConfig extends AbstractCommand
{
@VisibleForTesting
- @Arguments(title = "<autorepairparam> <value>", usage = "<autorepairparam>
<value>",
- description = "autorepair param and value.\nPossible autorepair parameters
are as following: " +
-
"[start_scheduler|number_of_repair_threads|min_repair_interval|sstable_upper_threshold"
+
-
"|enabled|table_max_repair_time|priority_hosts|forcerepair_hosts|ignore_dcs" +
-
"|history_clear_delete_hosts_buffer_interval|repair_primary_token_range_only" +
- "|parallel_repair_count|parallel_repair_percentage" +
-
"|allow_parallel_replica_repair|allow_parallel_repair_across_schedules" +
- "|materialized_view_repair_enabled|repair_max_retries" +
-
"|repair_retry_backoff|repair_session_timeout|min_repair_task_duration" +
- "|repair_by_keyspace|token_range_splitter.<property>]",
- required = true)
protected List<String> args = new ArrayList<>();
+ @Parameters(index = "0", arity = "0", description = { "Autorepair param
type.",
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
