Mmuzaf commented on code in PR #2497:
URL: https://github.com/apache/cassandra/pull/2497#discussion_r2200752736
##########
test/distributed/org/apache/cassandra/distributed/test/AbstractNodetoolStatusTest.java:
##########
@@ -108,11 +108,11 @@ public void testCommands()
// test illegal sort by or order
NodeToolResult invalidSortBy = NODE_1.nodetoolResult("status",
"--sort", "not_an_option");
invalidSortBy.asserts().failure();
- Assert.assertTrue(invalidSortBy.getStderr().contains("Illegal value
for -s/--sort used: 'not_an_option'. Supported values are state, ip, host,
load, owns, id, token, rack."));
+ Assert.assertTrue(invalidSortBy.getStdout().contains("Invalid value
for option '--sort': expected one of [state, ip, host, load, owns, id, token,
rack] (case-sensitive) but was 'not_an_option'"));
Review Comment:
Yes, this behavior has changed for a few commands that use enums or lists of
allowed values to validate input arguments.
The airline prints this error to stderr, while picocli prints it according
to the configured error handler. However, most commands print all other errors
errors to stdout and with this change now they are aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
