Mmuzaf commented on code in PR #2497:
URL: https://github.com/apache/cassandra/pull/2497#discussion_r2200887023
##########
src/java/org/apache/cassandra/tools/nodetool/DropCIDRGroup.java:
##########
@@ -20,21 +20,20 @@
import java.util.ArrayList;
import java.util.List;
-import io.airlift.airline.Arguments;
-import io.airlift.airline.Command;
import org.apache.cassandra.auth.AuthKeyspace;
import org.apache.cassandra.tools.NodeProbe;
-import org.apache.cassandra.tools.NodeTool.NodeToolCmd;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Parameters;
import static com.google.common.base.Preconditions.checkArgument;
/**
* Nodetool command to drop a CIDR group and associated mapping from the table
{@link AuthKeyspace#CIDR_GROUPS}
*/
@Command(name = "dropcidrgroup", description = "Drop an existing cidr group")
-public class DropCIDRGroup extends NodeToolCmd
+public class DropCIDRGroup extends AbstractCommand
{
- @Arguments(usage = "<cidrGroup>", description = "Requires a cidr group
name")
+ @Parameters(paramLabel = "cidrGroup", description = "Requires a cidr group
name")
Review Comment:
Fixed.
##########
src/java/org/apache/cassandra/tools/nodetool/EnableHintsForDC.java:
##########
@@ -20,17 +20,16 @@
import java.util.ArrayList;
import java.util.List;
-import io.airlift.airline.Arguments;
-import io.airlift.airline.Command;
import org.apache.cassandra.tools.NodeProbe;
-import org.apache.cassandra.tools.NodeTool;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Parameters;
import static com.google.common.base.Preconditions.checkArgument;
@Command(name = "enablehintsfordc", description = "Enable hints for a data
center that was previsouly disabled")
-public class EnableHintsForDC extends NodeTool.NodeToolCmd
+public class EnableHintsForDC extends AbstractCommand
{
- @Arguments(usage = "<datacenter>", description = "The data center to
enable")
+ @Parameters(paramLabel = "datacenter", description = "The data center to
enable")
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
