blambov commented on code in PR #4245:
URL: https://github.com/apache/cassandra/pull/4245#discussion_r2204041078
##########
src/java/org/apache/cassandra/dht/Token.java:
##########
@@ -75,6 +76,15 @@ public ByteSource asComparableBytes(Token token,
ByteComparable.Version version)
*/
public abstract Token fromComparableBytes(ByteSource.Peekable
comparableBytes, ByteComparable.Version version);
+ public void skipComparableBytes(ByteSource.Peekable comparableBytes,
ByteComparable.Version version, IPartitioner partitioner)
+ {
+ if (partitioner.isFixedLength())
+ ByteSourceInverse.skipBytes(comparableBytes,
partitioner.getMaxTokenSize());
Review Comment:
As there is no way to understand if this is correct by looking at the
surrounding code, this method should not be implemented here. It should be in
the individual token classes where `asComparableBytes` and
`fromComparableBytes` are implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
