blambov commented on PR #4245: URL: https://github.com/apache/cassandra/pull/4245#issuecomment-3101775265
A partition position includes information about the inclusiveness (`Token.maxKeyBound` vs `Token.minKeyBound`) and isn't affected by the memtable's treatment of tokens. The thing that is affected is the distribution of data among the shards of the memtable, which isn't visible to anything that writes or accesses memtable data. It is very relevant to this ticket, however, because the wrong inclusiveness makes the alignment we are looking for either: - wrong, if we are only taking the token without the inclusiveness information, meaning that we are not counting data that falls on the boundary, or - not able to kick in, if we use the inclusiveness information, because the memtable shards are one key off from the on-disk shards. Thus I do believe this pull request is the right place to fix this error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
