dcapwell commented on code in PR #4220:
URL: https://github.com/apache/cassandra/pull/4220#discussion_r2211031149
##########
src/java/org/apache/cassandra/db/Mutation.java:
##########
@@ -552,17 +570,18 @@ private Serialization serialization(Mutation mutation,
int version)
}
static void
serializeInternal(PartitionUpdate.PartitionUpdateSerializer serializer,
- Mutation mutation,
- DataOutputPlus out,
- int version) throws IOException
+ Mutation mutation,
+ DataOutputPlus out,
+ int version) throws IOException
{
Map<TableId, PartitionUpdate> modifications =
mutation.modifications;
if (version >= VERSION_51)
{
int flags = 0;
flags |=
potentialTxnConflictsFlag(mutation.potentialTxnConflicts);
- out.write(flags);
+ flags |= userTimestampFlag(mutation.userTimestamp);
+ out.writeUnsignedVInt32(flags);
Review Comment:
you right right, i got confused thinking this was `write int` but its `write
byte`.
> With versioning of serialization we don't really need to burn instructions
on a vint unless we want to add flags without bumping the version?
We get 8 flags before we care and this patch gets us to 2; so we really
don't need it atm.
Ill revert back to `write
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
