belliottsmith commented on code in PR #4220:
URL: https://github.com/apache/cassandra/pull/4220#discussion_r2218889210
##########
test/simulator/main/org/apache/cassandra/simulator/systems/InterceptibleThreadFactory.java:
##########
@@ -58,7 +58,9 @@ public InterceptibleThread newThread(Runnable runnable)
@Override
protected synchronized InterceptibleThread newThread(ThreadGroup
threadGroup, Runnable runnable, String name)
{
- InterceptibleThread thread = new InterceptibleThread(threadGroup,
runnable, name, extraToStringInfo, onTermination,
parent.interceptorOfGlobalMethods, time);
+ // Can not use NamedThreadFactory.globalPrefix() as this method
runs in the App class loader and not the Instance class loader; the
ThreadGroup's name can act as a proxy for this.
+ String threadName = threadGroup.getName() + '_' + name;
Review Comment:
Is there no way to have the logs include the thread group name, rather than
replicating it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
