dcapwell commented on code in PR #4238: URL: https://github.com/apache/cassandra/pull/4238#discussion_r2224004823
########## src/java/org/apache/cassandra/metrics/AccordMetrics.java: ########## @@ -212,112 +255,128 @@ else if (txnId.isSomeRead()) } @Override - public void onStable(Command cmd) + public void onStable(SafeCommandStore safeStore, Command cmd) { + Tracing.trace("Stable {} on {}", cmd.txnId(), safeStore.commandStore()); Review Comment: did we ever get tracing to work with accord? I recall it didn't work but don't recall us fixing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org