dcapwell commented on code in PR #4238:
URL: https://github.com/apache/cassandra/pull/4238#discussion_r2229092066
##########
src/java/org/apache/cassandra/metrics/AccordMetrics.java:
##########
@@ -212,112 +255,128 @@ else if (txnId.isSomeRead())
}
@Override
- public void onStable(Command cmd)
+ public void onStable(SafeCommandStore safeStore, Command cmd)
{
+ Tracing.trace("Stable {} on {}", cmd.txnId(),
safeStore.commandStore());
long now = AccordTimeService.nowMicros();
AccordMetrics metrics = forTransaction(cmd.txnId());
if (metrics != null)
{
long trxTimestamp = cmd.txnId().hlc();
- metrics.stableLatency.update(now - trxTimestamp,
TimeUnit.MICROSECONDS);
+ metrics.replicaStableLatency.update(now - trxTimestamp,
TimeUnit.MICROSECONDS);
}
}
@Override
- public void onPreApplied(Command cmd)
+ public void onPreApplied(SafeCommandStore safeStore, Command cmd)
{
+ Tracing.trace("Preapplied {} on {}", cmd.txnId(),
safeStore.commandStore());
long now = AccordTimeService.nowMicros();
AccordMetrics metrics = forTransaction(cmd.txnId());
if (metrics != null)
{
Timestamp trxTimestamp = cmd.txnId();
- metrics.preapplyLatency.update(now - trxTimestamp.hlc(),
TimeUnit.MICROSECONDS);
+ metrics.replicaPreapplyLatency.update(now -
trxTimestamp.hlc(), TimeUnit.MICROSECONDS);
PartialDeps deps = cmd.partialDeps();
- metrics.localDependencies.update(deps != null ?
deps.txnIdCount() : 0);
+ metrics.replicaDependencies.update(deps != null ?
deps.txnIdCount() : 0);
}
}
@Override
- public void onApplied(Command cmd, long applyStartTimestamp)
+ public void onApplied(SafeCommandStore safeStore, Command cmd, long t0)
Review Comment:
the accord bug was fixed, so the only open comment is the name change. This
is a `nit` so can be ignored if you don't agree (you did make the change in
accord)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
