yifan-c commented on code in PR #239:
URL: https://github.com/apache/cassandra-sidecar/pull/239#discussion_r2257762723
##########
server/src/main/java/org/apache/cassandra/sidecar/config/yaml/SidecarConfigurationImpl.java:
##########
@@ -303,17 +300,6 @@ public LiveMigrationConfiguration
liveMigrationConfiguration()
return liveMigrationConfiguration;
}
- public static SidecarConfigurationImpl readYamlConfiguration(String
yamlConfigurationPath) throws IOException
- {
- try
- {
- return readYamlConfiguration(Paths.get(new
URI(yamlConfigurationPath)));
- }
- catch (URISyntaxException e)
- {
- throw new IOException("Invalid URI: " + yamlConfigurationPath, e);
- }
- }
Review Comment:
I see. This method is not used anywhere. +1 on removing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
