frankgh commented on code in PR #239:
URL: https://github.com/apache/cassandra-sidecar/pull/239#discussion_r2263757848
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/ApiEndpointsV1.java:
##########
@@ -157,6 +157,11 @@ public final class ApiEndpointsV1
public static final String LIVE_MIGRATION_FILE_TRANSFER_API =
LIVE_MIGRATION_FILES_API + "/:" + DIR_TYPE_PARAM
+ "/:" +
DIR_INDEX_PARAM + "/*";
+ public static final String OPENAPI_ROUTE = "/openapi";
+ public static final String OPENAPI_JSON_ROUTE = "/openapi.json";
+ public static final String OPENAPI_YAML_ROUTE = "/openapi.yaml";
+ public static final String OPENAPI_HTML_ROUTE = "/openapi.html";
Review Comment:
NIT
```suggestion
public static final String OPENAPI_JSON_ROUTE = OPENAPI_ROUTE + ".json";
public static final String OPENAPI_YAML_ROUTE = OPENAPI_ROUTE + ".yaml";
public static final String OPENAPI_HTML_ROUTE = OPENAPI_ROUTE + ".html";
```
##########
NOTICE.txt:
##########
@@ -4,3 +4,6 @@ Copyright 2023- The Apache Software Foundation
This product includes software developed by The Apache Software
Foundation (http://www.apache.org/).
+This product includes the Jakarta RESTful Web Services API (jakarta.ws.rs-api),
+licensed under the Eclipse Public License 2.0 and/or the GNU General Public
License v2.0 with the Classpath Exception.
Review Comment:
Since we are choosing the EPL license, let's change the verbiage to this
```suggestion
licensed under the Eclipse Public License 2.0.
```
##########
server/src/main/resources/openapi-ui.html:
##########
@@ -0,0 +1,62 @@
+<!-- HTML for static distribution bundle build -->
+<!DOCTYPE html>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitatins under the License.
Review Comment:
```suggestion
limitations under the License.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
