k-rus commented on code in PR #4038:
URL: https://github.com/apache/cassandra/pull/4038#discussion_r2278536350
##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java:
##########
@@ -229,8 +237,9 @@ private void validateIndexTarget(TableMetadata table,
IndexMetadata.Kind kind, I
AbstractType<?> baseType = column.type.unwrap();
- if ((kind == IndexMetadata.Kind.CUSTOM) &&
!SchemaConstants.isValidName(target.column.toString()))
- throw ire(INVALID_CUSTOM_INDEX_TARGET, target.column,
SchemaConstants.NAME_LENGTH);
+ // This check will be removed with CASSANDRA-20235
Review Comment:
> The codebase is not a notepad.
Can you explain your intention with this phrase, so I am not misinterpreting
it?
> You already have Jira, so why do you need this kind of meaningless record?
To me it's not meaningless, since otherwise I will not be surprised that
reviewers would complain of not doing the correct fix for this place. In
general I am on the side of not having TODOs in the code and have them only in
tickets. Here I find it's useful to have a comment with the reference to the
ticket, and I got impression that it's preferred approach in C*. Do you want me
to improve the comments?
> Have you seen similar notepad messages in recent Cassandra code?
I find 1176 comments with references to Jira's tickets in C* java code. I
haven't checked how fresh are they. I also don't find any notes in the
contribution style about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
