k-rus commented on code in PR #4038:
URL: https://github.com/apache/cassandra/pull/4038#discussion_r2278660172
##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateIndexStatement.java:
##########
@@ -229,8 +237,9 @@ private void validateIndexTarget(TableMetadata table,
IndexMetadata.Kind kind, I
AbstractType<?> baseType = column.type.unwrap();
- if ((kind == IndexMetadata.Kind.CUSTOM) &&
!SchemaConstants.isValidName(target.column.toString()))
- throw ire(INVALID_CUSTOM_INDEX_TARGET, target.column,
SchemaConstants.NAME_LENGTH);
+ // This check will be removed with CASSANDRA-20235
Review Comment:
> 2、I think even the author mark this down, the author should have a basic
test case to cover it . what if the author forget to remove it in
[CASSANDRA-20235](https://issues.apache.org/jira/browse/CASSANDRA-20235) ? and
how we can find it ? Of course, if we are lucky, there are other test cases
that can cover it.
Can you clarify what test you mean? I don't think you suggest to have a
test, which fails until this task is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
