ekaterinadimitrova2 commented on code in PR #4038: URL: https://github.com/apache/cassandra/pull/4038#discussion_r2280976681
########## .circleci/config.yml: ########## Review Comment: @Maxwell-Guo > What I want to express is that the submitter should provide a clearer code. Yes, agreed. That is why the common practice in the project regarding CircleCI is to have the paid config submitted in a separate commit with a comment that it should not be committed. The only way to use the config in CircleCI is if you have that committed change in your branch you test. It is removed before final actual commit to Cassandra repo. > my circle ci environment I am afraid this has nothing to do with any private entity environment. CircleCI is a CI adopted by the Cassandra project. Though the main one is Jenkins. How to push the paid config to be able to run Python tests is also explained as part of the readme. We were even releasing based on CircleCI runs. The main reason for that option to exist is non-committers who do not have access to the Apache Jenkins CI, and because its resources are limited. Also, it serves as a backup CI environment. https://cassandra.apache.org/_/development/ci.html With that said, I see that @k-rus didn't put it in a separate commit, and it can be confusing and also harder to revert it at the end. @k-rus, please ensure you add that config in a separate commit. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
