k-rus commented on code in PR #4038:
URL: https://github.com/apache/cassandra/pull/4038#discussion_r2281701393
##########
src/java/org/apache/cassandra/schema/TableMetadata.java:
##########
@@ -813,7 +860,7 @@ public TableMetadata withUpdatedUserType(UserType udt)
protected void except(String format, Object... args)
{
- throw new ConfigurationException(keyspace + "." + name + ": " +
format(format, args));
+ throw new ConfigurationException(keyspace + '.' + name + ": " +
format(format, args));
Review Comment:
Are you asking why I think a char constant is better than a string with a
single char? Or why is this change done in this PR?
For the latter I tried to briefly explain in the PR and in the commit
message that it's a fix of a linter warning in a related file. I didn't go into
details of the motivation, which is:
I expect that my contribution needs to be of good quality and using an IDEA
linter is helpful tool to improve code. However, many warnings appear on
untouched lines, which makes it harder to focus on the warnings related to my
own changes. In general I believe it's good to improve code quality eventually.
I understand that it's preferable to do it in separate PRs, but the overhead of
doing a PR for such minor fixes is huge.
As a tradeoff, having a separate commit with these fixes within the same PR
could be a good solution. Otherwise, I doubt these issues will be addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
