k-rus commented on code in PR #4038:
URL: https://github.com/apache/cassandra/pull/4038#discussion_r2281765123


##########
.gitignore:
##########
@@ -57,6 +57,9 @@ ide/nbproject/private
 nb-configuration.xml
 nbactions.xml
 
+#VS code

Review Comment:
   Sounds that it's controversial to use VS code and exclude its local files, 
while it's acceptable to use IntelliJ, Eclipse, NetBeans. Note it's already 
part of [cassandra-dtest](https://github.com/apache/cassandra-dtest), i.e., it 
was accepted by the community.
   This change is in a different commit from the main contribution and without 
this change it will be easy to commit files from `.vscode` folder, which will 
be garbage to the project.
   I can create a separate Jira ticket and mention in the commit, but it will 
be overkill for everyone to manage additional ticket. Also separate PR is 
unfortunately an overkill for such minor change with current overhead.
   
   It would be nice that such issues were already fixed and I and other new 
contributors can just focus on the main work of a ticket. Other approach is a 
quick process to deliver simple fixes. Currently I am horrified how much time I 
will need to invest and how long time it will take to deliver such couple of 
lines change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org

Reply via email to