dcapwell commented on code in PR #4322:
URL: https://github.com/apache/cassandra/pull/4322#discussion_r2283263336
##########
src/java/org/apache/cassandra/service/accord/txn/TxnWrite.java:
##########
@@ -293,17 +296,20 @@ public Update complete(AccordUpdateParameters parameters,
TableMetadatas tables)
baseUpdate.rowCount(),
baseUpdate.canHaveShadowedData());
- UpdateParameters up =
parameters.updateParameters(baseUpdate.metadata(), key, index);
+ UpdateParameters up =
parameters.updateParameters(baseUpdate.metadata(), key, index, timestamp);
TxnData data = parameters.getData();
Row staticRow = applyUpdates(baseUpdate.staticRow(),
referenceOps.statics, key, Clustering.STATIC_CLUSTERING, up, data);
if (!staticRow.isEmpty())
updateBuilder.add(staticRow);
- Row existing = baseUpdate.hasRows() ?
Iterables.getOnlyElement(baseUpdate) : null;
- Row row = applyUpdates(existing, referenceOps.regulars, key,
referenceOps.clustering, up, data);
Review Comment:
for `applyUpdates` to do anything you need 2 things
1) `operations` is not empty
2) you have a `clustering`
if you have regular ops you should also have a clustering key, so this
behavior doesn't change in the loop. `clustering` was nullable but don't
recall how that was handled. Stuff like range tombstones don't have a
clustering and i think they go through this code path... now the list is empty
so `applyUpdates` won't be called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
