dcapwell commented on code in PR #4322: URL: https://github.com/apache/cassandra/pull/4322#discussion_r2283269179
########## test/distributed/org/apache/cassandra/distributed/test/accord/AccordCQLTestBase.java: ########## @@ -50,6 +50,13 @@ import org.apache.cassandra.config.Config.PaxosVariant; import org.apache.cassandra.cql3.CQLTester; import org.apache.cassandra.cql3.ast.Symbol; +import org.apache.cassandra.cql3.ast.AssignmentOperator; Review Comment: this test was actually written in https://github.com/apache/cassandra/pull/4299 and got forked into its own patch, but that didn't have all the AST changes needed so I had to rewrite it to be strings instead... this just reverts back to using the AST lib ########## test/distributed/org/apache/cassandra/distributed/test/accord/AccordCQLTestBase.java: ########## @@ -3239,19 +3246,16 @@ public void setComplexWithReferenceOnAnotherColumn() throws Exception ICoordinator coordinator = cluster.coordinator(1); coordinator.execute("INSERT INTO " + qualifiedAccordTableName + "(k, c, v0, v1) VALUES (0, 0, {0}, 1)", QUORUM); - String cql = "BEGIN TRANSACTION\n" + Review Comment: this test was actually written in https://github.com/apache/cassandra/pull/4299 and got forked into its own patch, but that didn't have all the AST changes needed so I had to rewrite it to be strings instead... this just reverts back to using the AST lib -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
