sklaha commented on code in PR #249: URL: https://github.com/apache/cassandra-sidecar/pull/249#discussion_r2289641662
########## adapters/adapters-base/src/main/java/org/apache/cassandra/sidecar/adapters/base/jmx/MeterMetricsJmxOperations.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.adapters.base.jmx; + +/** + * An interface that pulls meter metric methods from Cassandra JMX proxy. + * Meter metrics track the rate of events occurring over time. + */ +public interface MeterMetricsJmxOperations +{ + + /** + * Returns the total number of events that have occurred. + * @return the total count of events + */ + long getCount(); + + /** + * Returns the mean rate of events per second over the entire lifetime of the meter. + * @return the mean rate in events per second + */ + double getMeanRate(); + + /** + * Returns the one-minute exponentially-weighted moving average rate. + * @return the one-minute rate in events per second + */ + double getOneMinuteRate(); Review Comment: Removed. ########## adapters/adapters-base/src/main/java/org/apache/cassandra/sidecar/adapters/base/jmx/MeterMetricsJmxOperations.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.adapters.base.jmx; + +/** + * An interface that pulls meter metric methods from Cassandra JMX proxy. + * Meter metrics track the rate of events occurring over time. + */ +public interface MeterMetricsJmxOperations +{ + + /** + * Returns the total number of events that have occurred. + * @return the total count of events + */ + long getCount(); + + /** + * Returns the mean rate of events per second over the entire lifetime of the meter. + * @return the mean rate in events per second + */ + double getMeanRate(); + + /** + * Returns the one-minute exponentially-weighted moving average rate. + * @return the one-minute rate in events per second + */ + double getOneMinuteRate(); + + /** + * Returns the five-minute exponentially-weighted moving average rate. + * @return the five-minute rate in events per second + */ + double getFiveMinuteRate(); Review Comment: Removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
