sklaha commented on code in PR #249: URL: https://github.com/apache/cassandra-sidecar/pull/249#discussion_r2289660946
########## integration-tests/src/integrationTest/org/apache/cassandra/sidecar/routes/CompactionStatsIntegrationTest.java: ########## @@ -0,0 +1,372 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.sidecar.routes; + +import java.util.ArrayList; +import java.util.List; + +import org.junit.jupiter.api.Test; + +import io.vertx.core.buffer.Buffer; +import io.vertx.core.http.HttpResponseExpectation; +import io.vertx.ext.web.client.HttpResponse; +import org.apache.cassandra.sidecar.common.response.CompactionStatsResponse; +import org.apache.cassandra.sidecar.common.response.data.ActiveCompactionEntry; +import org.apache.cassandra.sidecar.testing.QualifiedName; +import org.apache.cassandra.sidecar.testing.SharedClusterSidecarIntegrationTestBase; + +import static org.apache.cassandra.testing.TestUtils.DC1_RF1; +import static org.apache.cassandra.testing.TestUtils.TEST_KEYSPACE; +import static org.apache.cassandra.testing.TestUtils.TEST_TABLE_PREFIX; +import static org.apache.cassandra.testing.utils.AssertionUtils.getBlocking; +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Integration tests for the Compaction Statistics API endpoint. + * + * <p>Tests the compaction statistics functionality by generating large-scale SSTable data across + * multiple tables, triggering concurrent compactions, and validating API responses in both active + * and completed compaction scenarios.</p> + * + * <h2>Testing Mechanism</h2> + * <ul> + * <li><strong>Data Setup:</strong> Creates 5 tables with 100 SSTables each (500 total, 1000 records per SSTable)</li> + * <li><strong>Concurrency:</strong> Triggers compactions simultaneously using separate threads</li> + * <li><strong>Active Detection:</strong> Polls API immediately with retry logic to catch in-progress compactions</li> + * <li><strong>Comprehensive Validation:</strong> Validates all response fields including statistics, rates, + * pending tasks, and detailed active compaction data when available</li> + * <li><strong>Dual Success:</strong> Test passes whether active compactions are captured or completed</li> + * </ul> + */ +class CompactionStatsIntegrationTest extends SharedClusterSidecarIntegrationTestBase +{ + private static final String COMPACTION_STATS_ROUTE = "/api/v1/cassandra/stats/compaction"; + private static final int MAX_POLL_ATTEMPTS = 10; + private static final List<QualifiedName> TEST_TABLES = new ArrayList<>(); + private static final int TABLE_COUNT = 5; + + @Override + protected void initializeSchemaForTest() + { + createTestKeyspace(TEST_KEYSPACE, DC1_RF1); + + for (int i = 1; i <= TABLE_COUNT; i++) + { + TEST_TABLES.add(new QualifiedName(TEST_KEYSPACE, TEST_TABLE_PREFIX + "_compaction_" + i)); + } + + // Create test tables for compaction activity + for (QualifiedName tableName : TEST_TABLES) + { + createTestTable(tableName, + "CREATE TABLE %s ( \n" + + " id int PRIMARY KEY, \n" + + " data text \n" + + ");"); + } + } + + @Test + void testCompactionStatsRetrieval() + { + logger.info("Starting compaction stats test with {} tables", TEST_TABLES.size()); + + // Generate SSTables for all test tables + for (QualifiedName tableName : TEST_TABLES) + { + generateSSTables(tableName, 100); + } + + // Create threads to trigger compaction on all tables + List<Thread> compactionThreads = new ArrayList<>(); + for (QualifiedName tableName : TEST_TABLES) + { + Thread thread = new Thread(() -> triggerCompactionForTable(tableName)); + compactionThreads.add(thread); + } + + // Start all compaction threads + for (Thread thread : compactionThreads) + { + thread.start(); + } + + // Poll immediately and repeatedly to catch active compactions + CompactionStatsResponse stats = null; + HttpResponse<Buffer> response; + boolean foundActiveCompactions; + + for (int attempt = 0; attempt < MAX_POLL_ATTEMPTS; attempt++) Review Comment: /** * Run the assertions in a loop until the first success within the timeout. * Otherwise, it fails with the last assertion failure. * * @param timeoutSeconds timeout * @param assertions assertions */ public static void loopAssert(int timeoutSeconds, int delayMillis, Runnable assertions) I don't want to fail the test if it's unable to catch an active compaction. But I want to fail the test for other assertions. It will be difficult to use loopAssert unless I write another version of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
