tolbertam commented on code in PR #4304:
URL: https://github.com/apache/cassandra/pull/4304#discussion_r2307660874
##########
test/unit/org/apache/cassandra/tools/nodetool/SetAutoRepairConfigTest.java:
##########
@@ -268,7 +268,8 @@ public static Collection<Object[]> testCases()
forEachRepairType("ignore_dcs", "dc1,dc2", (type) -> verify(probe,
times(1)).setAutoRepairIgnoreDCs(type.name(), ImmutableSet.of("dc1", "dc2"))),
forEachRepairType("token_range_splitter.max_bytes_per_schedule",
"500GiB", (type) -> verify(probe,
times(1)).setAutoRepairTokenRangeSplitterParameter(type.name(),
"max_bytes_per_schedule", "500GiB")),
forEachRepairType("repair_max_retries", "3", (type) ->
verify(probe, times(1)).setAutoRepairMaxRetriesCount(type.name(), 3)),
- forEachRepairType("repair_retry_backoff", "60s", (type) ->
verify(probe, times(1)).setAutoRepairRetryBackoff(type.name(), "60s"))
+ forEachRepairType("repair_retry_backoff", "60s", (type) ->
verify(probe, times(1)).setAutoRepairRetryBackoff(type.name(), "60s")),
+ forEachRepairType("mixed_major_version_repair_enabled", "false",
(type) -> verify(probe, times(1)).setMixedMajorVersionRepairEnabled(false))
Review Comment:
Since this isn't by repair type, it can probably just be in its own test
like `testHistoryDeleteHostsClearBufferInSec`
##########
test/unit/org/apache/cassandra/tools/nodetool/SetAutoRepairConfigTest.java:
##########
@@ -268,7 +268,8 @@ public static Collection<Object[]> testCases()
forEachRepairType("ignore_dcs", "dc1,dc2", (type) -> verify(probe,
times(1)).setAutoRepairIgnoreDCs(type.name(), ImmutableSet.of("dc1", "dc2"))),
forEachRepairType("token_range_splitter.max_bytes_per_schedule",
"500GiB", (type) -> verify(probe,
times(1)).setAutoRepairTokenRangeSplitterParameter(type.name(),
"max_bytes_per_schedule", "500GiB")),
forEachRepairType("repair_max_retries", "3", (type) ->
verify(probe, times(1)).setAutoRepairMaxRetriesCount(type.name(), 3)),
- forEachRepairType("repair_retry_backoff", "60s", (type) ->
verify(probe, times(1)).setAutoRepairRetryBackoff(type.name(), "60s"))
+ forEachRepairType("repair_retry_backoff", "60s", (type) ->
verify(probe, times(1)).setAutoRepairRetryBackoff(type.name(), "60s")),
+ forEachRepairType("mixed_major_version_repair_enabled", "false",
(type) -> verify(probe, times(1)).setMixedMajorVersionRepairEnabled(false))
Review Comment:
Since this isn't by repair type now, it can probably just be in its own test
like `testHistoryDeleteHostsClearBufferInSec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
