himanshujindal commented on PR #4304: URL: https://github.com/apache/cassandra/pull/4304#issuecomment-3226130821
@tolbertam Thanks for your feedback. I have addressed all of it except adding metrics. Let me know if that is a blocker and I can get to it next week. If metrics is a blocker, can you share the metric name and purpose? That way, it is easier for me to add the metric. Also, I have run pre-ci testing on the commit and the tests look good - https://pre-ci.cassandra.apache.org/job/cassandra/74/testReport/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
