lukasz-antoniak commented on code in PR #2037:
URL:
https://github.com/apache/cassandra-java-driver/pull/2037#discussion_r2319844832
##########
core/src/main/java/com/datastax/oss/driver/api/core/tracker/RequestTracker.java:
##########
@@ -47,21 +47,22 @@ default void onSuccess(
@NonNull Node node) {}
/**
- * Invoked each time a request succeeds.
+ * Invoked each time a session request succeeds. A session request is a
`session.execute()` call
*
* @param latencyNanos the overall execution time (from the {@link
Session#execute(Request,
* GenericType) session.execute} call until the result is made available
to the client).
* @param executionProfile the execution profile of this request.
* @param node the node that returned the successful response.
- * @param requestLogPrefix the dedicated log prefix for this request
+ * @param sessionRequestLogPrefix the dedicated log prefix for this request
*/
default void onSuccess(
@NonNull Request request,
long latencyNanos,
@NonNull DriverExecutionProfile executionProfile,
@NonNull Node node,
- @NonNull String requestLogPrefix) {
- // If client doesn't override onSuccess with requestLogPrefix delegate
call to the old method
+ @NonNull String sessionRequestLogPrefix) {
+ // If client doesn't override onSuccess with sessionRequestLogPrefix
delegate call to the old
Review Comment:
Convinced, yes that is OK and code is consistent with other overridden
methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
