smiklosovic commented on PR #4376: URL: https://github.com/apache/cassandra/pull/4376#issuecomment-3289382996
Hi @griffindvs , 1) could you please rebase this patch against the current 5.0? I am not sure how you did it but I have merge conflcts rebasing your branch against 5.0. The resolution of conflicts is very easy. Can you then force-push, please? 2) Why are we updating to 2.15.3 only? I have updated dataformat-yaml to 2.19.2 as well, that brings snakeyaml 2.4. So I updated snakeyaml from 2.1 to 2.4 too and it just compiles fine. It seems that Java changes in this patch are perfectly OK to run with snakeyaml 2.4 so I do not see why we could not do that. That also means that we can remove "exclusions" block in dataformat-yaml since everything would be aligned. I would just comment on snakeyaml that bumping this version is a little bit more involved because it is used in dataformat-yaml so we should be cautions when doing so. 3) More of a cosmetic change but still .... You personally are not the author of the Java-related changes. Raymond Huffman is. Your contribution in this patch consists of the second commit only which removed dependency check suppressions. In this case, the original author should be Raymond and you would be Co-authored-by. 4) we also need .snyk updated, right? 5) nit which will be resolved on merge but please, entries in CHANGES.txt are added always on top. Not at the end (I am aware you have not done it like that) 6) the entry in CHANGES.txt is not entirely accurate, we are not updating _jackson_ to 2.15.3, we are updating _jackson-dataformat-yaml_ 7) This is a little bit suspicious but when you do 'ant realclean && ant jar' and you look into build/test/lib/jars, you list the dir and grep it on "jackson", there are also dependencies for 2.11.3 instead of just 2.19.2. I am very curious from where these dependencies come from. in libs/ we have just 2.19.2 but in test jars it seems to bring more. I do not like this and it might have unpredictable behaviour when we mix jackson versions like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
