michaelsembwever commented on PR #4376: URL: https://github.com/apache/cassandra/pull/4376#issuecomment-3289457788
@smiklosovic, maybe you're throwing too much at a first time contributor here. the desire here is only to back-port what's in trunk. anything beyond that should be changes you smiklosovic can contribute 🙏 going through the feedback in a bit more detail… 1. you sure this isn't on your side ? this PR has cassandra-5.0 as the base branch. i see no conflicts here or when i test it locally. 2. 2.15.3 is what's in trunk. this patch is only about back-porting what's already been tested for a while in trunk. we want to minimise what we change in a back-port. so this initial action taken here by @griffindvs is correct. the problem is CASSANDRA-20848 that later introduces newer jackson version. we need to include its patch to. 3. the commits are correctly correct. so this applies when squashing the commits. and that can happen later. also note we have a precedent wrt commit message of back-ported commits. (but given this is @griffindvs's first contribution let's leave this to the person merging the commit). 4. yes 5. correct. CHANGES.txt in reverse chronological 6. this exists in the original commit too. let's not put that on @griffindvs , (one of us can fix the CHANGES.txt in this PR and for the original commit in trunk) 7. this is because of not yet including CASSANDRA-20848. the patch should end up like trunk, with: `jackson-annotations-2.13.4.jar jackson-core-2.19.2.jar jackson-databind-2.19.2.jar jackson-dataformat-yaml-2.19.2.jar` 8. related to (4) action plan: - include CASSANDRA-20848 - test OWASP (`ant dependency-check`) - update `.snyk` (see `.build/dependency-check-suppressions.xml`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
