belliottsmith commented on code in PR #251:
URL: https://github.com/apache/cassandra-accord/pull/251#discussion_r2361157220
##########
accord-core/src/main/java/accord/local/RedundantStatus.java:
##########
@@ -151,15 +155,15 @@ public enum Property
}
final boolean overrideWasOwned;
- final boolean mergeWithPreBootstrapOrStale;
+ final boolean mergeWithUnready;
Review Comment:
This is very inconsistent, perhaps from a previous attempt to change the
encoding. I think it's correct to say we have 32 bits to use here, now. But
you're right we could match the condition to this number. I ended up not yet
needing the extra bits, though, so I have for now also not upgraded the
serialization format. So I might leave the restriction to short. It's a
comparatively easy thing to fix later. But, I don't feel super strongly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
