belliottsmith commented on code in PR #251:
URL: https://github.com/apache/cassandra-accord/pull/251#discussion_r2361166585
##########
accord-core/src/main/java/accord/coordinate/ExecuteTxn.java:
##########
@@ -190,7 +186,7 @@ protected void startOnceInitialised()
Node.Id self = node.id();
if (permitLocalExecution() && tryIfUniversal(self))
{
- isPrivilegedVoteCommitting = true;
+ isPrivilegedVoteCommitting = txnId.hasPrivilegedCoordinator() &&
path == FAST;
Review Comment:
You might be mixing up two different mostly unrelated changes. This
particular line of code is just correctly limiting the privileged fast path
commit behaviour to those cases where we really need it. For instance, if we
don't have a privileged coordinator we can take the fast path whether or not we
successfully commit locally. So this is an isolated minor change just to ensure
we switch the behaviour on the correct condition.
If we ARE enacting a privileged fast path vote, then a NACK means we have to
take the slow path (because the decision won't be durable to recovery - this
optimisation relies on the coordinator recording the vote outcome before anyone
else does).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
