belliottsmith commented on code in PR #4387:
URL: https://github.com/apache/cassandra/pull/4387#discussion_r2367764434
##########
src/java/org/apache/cassandra/service/accord/AccordDataStore.java:
##########
@@ -95,4 +88,23 @@ public void ensureDurable(CommandStore commandStore, Ranges
ranges, RedundantBef
prev = cfs;
}
}
+
+ @Override
+ public FetchResult fetch(Node node, SafeCommandStore safeStore, Ranges
ranges, SyncPoint syncPoint, FetchRanges callback, FetchKind kind)
+ {
+ switch (kind)
+ {
+ default: throw new UnhandledEnum(kind);
+ case Image:
+ {
+ AccordFetchCoordinator coordinator = new
AccordFetchCoordinator(node, ranges, syncPoint, callback,
safeStore.commandStore());
+ coordinator.start();
+ return coordinator.result();
+ }
+ case Sync:
+ {
+ throw new UnsupportedOperationException();
Review Comment:
No, it also supports bootstrapping a node that was previously bootstrapped.
That said, let me see about at least restoring this part of the patch, and we
can address the journal replay issue in a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
