ifesdjeen commented on code in PR #4387:
URL: https://github.com/apache/cassandra/pull/4387#discussion_r2366972375
##########
src/java/org/apache/cassandra/service/accord/AccordJournal.java:
##########
@@ -716,6 +716,7 @@ public void close()
++cur;
}
+ return true;
Review Comment:
should we return false on corruption?
##########
.gitmodules:
##########
@@ -1,4 +1,4 @@
[submodule "modules/accord"]
path = modules/accord
- url = https://github.com/apache/cassandra-accord.git
- branch = trunk
+ url = https://github.com/belliottsmith/cassandra-accord.git
Review Comment:
I'm sure you had it in mind, but just for completeness, reminding to switch
branch.
##########
src/java/org/apache/cassandra/service/accord/AccordDataStore.java:
##########
@@ -95,4 +88,23 @@ public void ensureDurable(CommandStore commandStore, Ranges
ranges, RedundantBef
prev = cfs;
}
}
+
+ @Override
+ public FetchResult fetch(Node node, SafeCommandStore safeStore, Ranges
ranges, SyncPoint syncPoint, FetchRanges callback, FetchKind kind)
+ {
+ switch (kind)
+ {
+ default: throw new UnhandledEnum(kind);
+ case Image:
+ {
+ AccordFetchCoordinator coordinator = new
AccordFetchCoordinator(node, ranges, syncPoint, callback,
safeStore.commandStore());
+ coordinator.start();
+ return coordinator.result();
+ }
+ case Sync:
+ {
+ throw new UnsupportedOperationException();
Review Comment:
Is this implemented in some other way? I believe I had an implementation of
repair plugged in here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
