aweisberg commented on code in PR #4378:
URL: https://github.com/apache/cassandra/pull/4378#discussion_r2383284998
##########
src/java/org/apache/cassandra/tools/SSTableMetadataViewer.java:
##########
@@ -422,8 +422,9 @@ private void printSStableMetadata(File file, boolean scan)
throws IOException
field("ClusteringTypes", clusteringTypes.toString());
field("StaticColumns", FBUtilities.toString(statics));
field("RegularColumns", FBUtilities.toString(regulars));
- if (stats != null)
- field("IsTransient", stats.isTransient);
+ // TODO (review): This should be removed right? Nothing depends on
it?
+// if (stats != null)
+// field("IsTransient", stats.isTransient);
Review Comment:
The problem is poorly written tools can see the field missing and start
erroring out. I'll put it back in for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
