aratno commented on code in PR #4378:
URL: https://github.com/apache/cassandra/pull/4378#discussion_r2383374536
##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateTableStatement.java:
##########
@@ -167,11 +166,12 @@ public Keyspaces apply(ClusterMetadata metadata)
TableMetadata table = builder.build();
table.validate();
- if (keyspace.replicationStrategy.hasTransientReplicas()
- && table.params.readRepair != ReadRepairStrategy.NONE)
- {
- throw ire("read_repair must be set to 'NONE' for transiently
replicated keyspaces");
- }
+ // TODO (review): This can be removed right? ReadRepair is effectively
not done anymore so the setting doesn't matter
+// if (keyspace.replicationStrategy.hasTransientReplicas()
+// && table.params.readRepair != ReadRepairStrategy.NONE)
+// {
+// throw ire("read_repair must be set to 'NONE' for transiently
replicated keyspaces");
+// }
Review Comment:
Makes sense, I support moving forward with that option essentially ignored
for now. We could also drop a client warning if a user has mutation tracking
enabled for a keyspace with read repair NONE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
