maedhroz commented on code in PR #4393:
URL: https://github.com/apache/cassandra/pull/4393#discussion_r2388433877
##########
src/java/org/apache/cassandra/db/guardrails/Guardrails.java:
##########
@@ -143,6 +143,20 @@ public final class Guardrails implements GuardrailsMBean
state ->
CONFIG_PROVIDER.getOrCreate(state).getTablePropertiesDisallowed(),
"Table Properties");
+ /**
+ * Guardrail warning about, ignoring or rejecting the usage of certain
keyspace properties.
+ */
+ public static final Values<String> keyspaceProperties =
+ new Values<>("keyspace_properties",
+ null,
+ state ->
CONFIG_PROVIDER.getOrCreate(state).getKeyspacePropertiesWarned(),
+ state ->
CONFIG_PROVIDER.getOrCreate(state).getKeyspacePropertiesIgnored(),
+ state ->
CONFIG_PROVIDER.getOrCreate(state).getKeyspacePropertiesDisallowed()
+ .stream()
+ .filter(prop -> !"replication".equals(prop))
Review Comment:
> Hence I think the proper way would be to filter it out explicitly in
validateKeyspaceProperties (and also inform a user, by logging, that such a
property is ignored altogether when using this guardrail).
Yes, this is the way to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
