smiklosovic commented on code in PR #4393:
URL: https://github.com/apache/cassandra/pull/4393#discussion_r2390334114
##########
src/java/org/apache/cassandra/db/guardrails/Guardrails.java:
##########
@@ -143,6 +143,20 @@ public final class Guardrails implements GuardrailsMBean
state ->
CONFIG_PROVIDER.getOrCreate(state).getTablePropertiesDisallowed(),
"Table Properties");
+ /**
+ * Guardrail warning about, ignoring or rejecting the usage of certain
keyspace properties.
+ */
+ public static final Values<String> keyspaceProperties =
+ new Values<>("keyspace_properties",
+ null,
+ state ->
CONFIG_PROVIDER.getOrCreate(state).getKeyspacePropertiesWarned(),
+ state ->
CONFIG_PROVIDER.getOrCreate(state).getKeyspacePropertiesIgnored(),
+ state ->
CONFIG_PROVIDER.getOrCreate(state).getKeyspacePropertiesDisallowed()
+ .stream()
+ .filter(prop -> !"replication".equals(prop))
Review Comment:
@maedhroz sure, we can do this too. So we clearly declare this to a user
instead of silently proceeding and users thinking it is all fine.
@aparnanaik0522 please rebase your patch on top of the current trunk, now it
has like 10 commits, completely unrelated to this patch. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
