nvharikrishna commented on code in PR #259:
URL: https://github.com/apache/cassandra-sidecar/pull/259#discussion_r2404256639
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/request/LiveMigrationDataCopyRequest.java:
##########
@@ -58,18 +52,6 @@ public
LiveMigrationDataCopyRequest(@JsonProperty("maxIterations") int maxIterat
@JsonProperty("successThreshold")
double successThreshold,
@JsonProperty("maxConcurrency") int
maxConcurrency)
{
- this(UUID.randomUUID().toString(), maxIterations, successThreshold,
maxConcurrency);
- }
-
- public LiveMigrationDataCopyRequest(String id,
- int maxIterations,
- double successThreshold,
- int maxConcurrency)
- {
- if (id == null || id.isEmpty())
Review Comment:
Having request ID at in reqeust is bit confusing when this class is used at
client. Handling requestId separately and returning it as part of response.
##########
server/src/main/java/org/apache/cassandra/sidecar/livemigration/DataCopyTaskManager.java:
##########
@@ -96,21 +93,8 @@ public Future<LiveMigrationTask> createTask(@NotNull
LiveMigrationDataCopyReques
InstanceMetadata localInstanceMetadata =
instancesMetadata.instanceFromHost(currentHost);
- return vertx.executeBlocking(() ->
liveMigrationMap.getSource(currentHost))
- .compose(source -> validateDataDirs(source,
localInstanceMetadata))
- .compose(source -> createDataCopyTask(request, source,
localInstanceMetadata));
- }
-
- Future<String> validateDataDirs(String source, InstanceMetadata
localInstanceMetadata)
- {
- InstanceMetadata sourceMeta =
instancesMetadata.instanceFromHost(source);
Review Comment:
`instancesMetadata.instanceFromHost(source);` doesn't work if the source is
not local. Hence removing it. Data copy will fail while downloading files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
