nvharikrishna commented on code in PR #259:
URL: https://github.com/apache/cassandra-sidecar/pull/259#discussion_r2452374286
##########
client-common/src/main/java/org/apache/cassandra/sidecar/common/request/LiveMigrationDataCopyRequest.java:
##########
@@ -58,18 +52,6 @@ public
LiveMigrationDataCopyRequest(@JsonProperty("maxIterations") int maxIterat
@JsonProperty("successThreshold")
double successThreshold,
@JsonProperty("maxConcurrency") int
maxConcurrency)
{
- this(UUID.randomUUID().toString(), maxIterations, successThreshold,
maxConcurrency);
- }
-
- public LiveMigrationDataCopyRequest(String id,
- int maxIterations,
- double successThreshold,
- int maxConcurrency)
- {
- if (id == null || id.isEmpty())
Review Comment:
> If client retry is not a consideration and the idea is ensure
server-generated IDs.
yes, this is the expectation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
