shalnisundram commented on code in PR #4408:
URL: https://github.com/apache/cassandra/pull/4408#discussion_r2409006175
##########
pylib/cqlshlib/test/test_cqlsh_completion.py:
##########
@@ -1048,12 +1048,12 @@ def test_complete_in_use(self):
'system_virtual_schema',
'system_cluster_metadata'])
def test_complete_in_create_index(self):
- self.trycompletions('CREATE I', immediate='NDEX ')
+ self.trycompletions('CREATE IN', immediate='DEX ')
self.trycompletions('CREATE INDEX ', choices=['<new_index_name>',
'IF', 'ON'])
self.trycompletions('CREATE INDEX example ', immediate='ON ')
def test_complete_in_drop_index(self):
- self.trycompletions('DROP I', immediate='NDEX ')
+ self.trycompletions('DROP IN', immediate='DEX ')
Review Comment:
Since "self.trycompletions('DROP I', choices=['DENTITY', 'NDEX '])" test is
making checks for both INDEX and IDENTITY, not just INDEX, should this stay in
the test_complete_in_drop_index() test? Or should these checks be moved
elsewhere? Could also rename the test to more accurately reflect these checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
