bbotella commented on code in PR #4408:
URL: https://github.com/apache/cassandra/pull/4408#discussion_r2408914289
##########
pylib/cqlshlib/test/test_cqlsh_completion.py:
##########
@@ -1184,9 +1184,15 @@ def test_complete_in_alter_type(self):
self.trycompletions('ALTER TYPE IF EXISTS new_type ADD IF NOT EXISTS
', choices=['<new_field_name>'])
self.trycompletions('ALTER TYPE IF EXISTS new_type RENAME ',
choices=['IF', '<quotedName>', '<identifier>'])
+ # USER checks
+ def test_complete_in_create_user(self):
+ self.trycompletions('CREATE USER ', choices=['<username>', 'IF'])
+ self.trycompletions('CREATE USER IF ', immediate='NOT EXISTS ')
Review Comment:
Good catch with the reordering. Not specifically related to the change for
this PR tho. What do you think @frankgh ? Should we follow the [Boy Scout
rule](https://biratkirat.medium.com/step-8-the-boy-scout-rule-robert-c-martin-uncle-bob-9ac839778385)
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
