smiklosovic commented on code in PR #4379:
URL: https://github.com/apache/cassandra/pull/4379#discussion_r2445144556


##########
src/java/org/apache/cassandra/auth/CassandraRoleManager.java:
##########
@@ -827,4 +853,52 @@ public void setInvalidClientDisconnectMaxJitterMillis(long 
duration)
         this.invalidClientDisconnectMaxJitterMillis = duration;
         scheduleDisconnectInvalidRoleTask();
     }
+
+    private static final ColumnSpecification GENERATED_PASSWORD_METADATA = new 
ColumnSpecification(SchemaConstants.AUTH_KEYSPACE_NAME,
+                                                                               
                    "generated_password",
+                                                                               
                    new ColumnIdentifier("generated_password", true),
+                                                                               
                    UTF8Type.instance);
+
+    private static final ColumnSpecification GENERATED_ROLE_NAME_METADATA = 
new ColumnSpecification(SchemaConstants.AUTH_KEYSPACE_NAME,
+                                                                               
                     "generated_role_name",
+                                                                               
                     new ColumnIdentifier("generated_role_name", true),

Review Comment:
   I think it is just fine as it is. Both things are generated. Once password, 
another time role_name ... 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to