smiklosovic commented on code in PR #4379:
URL: https://github.com/apache/cassandra/pull/4379#discussion_r2417281586


##########
src/antlr/Parser.g:
##########
@@ -1453,15 +1453,8 @@ createUserStatement returns [CreateRoleStatement stmt]
         {
            throw new SyntaxException("Options 'password' and 'hashed password' 
are mutually exclusive");
         }
-        if (opts.getPassword().isPresent() && opts.isGeneratedPassword())

Review Comment:
   removing generation from USER, USER is as of now (deprecated) alias to ROLE. 
Does not make sense to keep adding stuff to it. Same holds for changes in this 
patch when you see that USER-related logic was reverted back. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to