smiklosovic commented on code in PR #4427:
URL: https://github.com/apache/cassandra/pull/4427#discussion_r2474356338
##########
src/java/org/apache/cassandra/db/virtual/CredentialsCacheKeysTable.java:
##########
@@ -42,11 +41,7 @@ final class CredentialsCacheKeysTable extends
AbstractMutableVirtualTable
.addPartitionKeyColumn(ROLE, UTF8Type.instance)
.build());
- IAuthenticator authenticator = DatabaseDescriptor.getAuthenticator();
- if (authenticator instanceof PasswordAuthenticator)
- this.passwordAuthenticatorOptional =
Optional.of((PasswordAuthenticator) authenticator);
Review Comment:
I think now we have the opportunity to change name of this variable to
`maybePasswordAuthenticator`. If you check the codebase, naming like this is
more prevalent and reads better.
We also do not need `this.` here. There is no ambiguity as in what field we
are setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
