jcshepherd commented on code in PR #4427:
URL: https://github.com/apache/cassandra/pull/4427#discussion_r2488182029
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1294,7 +1294,7 @@ public static GuardrailsOptions getGuardrailsConfig()
return guardrails;
}
- private static void applyGuardrails()
+ public static void applyGuardrails()
Review Comment:
I'm not thrilled with this, but I didn't see a cleaner way of initializing
or defaulting guardrails config to enable CassandraRoleManager to construct in
a unit test environment, without fully initializing DatabaseDescriptor. (If
guardrails aren't explicitly initialized, CassandraRoleManager NPEs in the
constructor.) Open to other suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
