smiklosovic commented on code in PR #4459:
URL: https://github.com/apache/cassandra/pull/4459#discussion_r2527741039
##########
src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsPrinter.java:
##########
@@ -137,6 +137,7 @@ protected void printStatsTable(StatsTable table, String
tableDisplayName, String
out.println(indent + "Bloom filter off heap memory used: " +
table.bloomFilterOffHeapMemoryUsed);
if (table.indexSummaryOffHeapUsed)
out.println(indent + "Index summary off heap memory used: " +
table.indexSummaryOffHeapMemoryUsed);
+ out.println(indent + "Compression dictionaries memory used: " +
formatDataSize(Long.parseLong(table.compressionDictionariesMemoryUsed),
humanReadable));
Review Comment:
no, this is fine, believe me :D it is just it can be also null when not
backed by dictionary compression table, we are also doing this in this class
(formatDatasize) the same way but for primitive values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
