yifan-c commented on code in PR #4459:
URL: https://github.com/apache/cassandra/pull/4459#discussion_r2539295201
##########
src/java/org/apache/cassandra/db/compression/CompressionDictionary.java:
##########
@@ -56,6 +56,15 @@ public interface CompressionDictionary extends AutoCloseable
*/
int checksum();
+ /**
+ * Get memory occupied of this dictionary as a whole.
+ * Use for metrics exposing used memory in total. The value
+ * return by this method is a best-effort estimation.
+ *
+ * @return memory occuppied by this compression dictionary, in bytes
+ */
+ int estimatedOccupiedMemoryBytes();
Review Comment:
👍 on renaming the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
