aratno commented on code in PR #4428:
URL: https://github.com/apache/cassandra/pull/4428#discussion_r2539716047


##########
src/java/org/apache/cassandra/db/ReadExecutionController.java:
##########
@@ -243,4 +261,27 @@ private void addSample()
         if (cfs != null)
             cfs.metric.topLocalReadQueryTime.addSample(cql, timeMicros);
     }
+
+    public void addActivationIds(ColumnFamilyStore.ViewFragment view)
+    {
+        Preconditions.checkState(metadata().replicationType().isTracked());
+        if (activationIds == null)
+            activationIds = new HashSet<>();

Review Comment:
   We do actually access the same ReadExecutionController across threads, when 
an IN clause has multiple local partitions. I'll update this path to make it 
threadsafe.
   
   Not exactly the same, but similar to: CASSANDRA-19427



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to